66 replies to this topic

[littlesat]

Then to be compatible AMS should alter to our internal PIPzap.... But there exists a work-a-round now and it is also clear why it does work on other images... Probably AMS depends on the external PiPzap plugin?

But still what added value does AMS has....? probably we could adapt something of that????

Edited by littlesat, 17 June 2012 - 10:08.

[rtzhjgg0]

Then to be compatible AMS should alter to our internal PIPzap.... But there exists a work-a-round now and it is also clear why it does work on other images... Probably AMS depends on the external PiPzap plugin?

Yes, since PiPzap exists as a Plugin, nobody (exept PLi) uses patches. That plugin works on any image and is maintained continuously from his autor. So the autors of other plugins try to remain compatible to 'PiPzap-plugin'.

But still what added value does AMS has....? probably we could adapt something of that????

AMS have REALLY a great number options/functions. I love this ones:

-"Live" preview
-stop play a movie with EXIT
-Multiselection
-...

[Dima73]

The possibilities of this plugin(PiPzap) is high time to build in PLi.

[blzr]

AMS have REALLY a great number options/functions. I love this ones:
-"Live" preview

- what's the difference comparing to < > preview in openpli player?

-stop play a movie with EXIT

- and stop with [stop] button (and/or [tv]) is not enough?

-Multiselection

- multiselection of what?
//I know, maybe lame questions, but never used this AMS plugin, so just curious...

[Dima73]

In fact, AMC оne very useful feature.
Save the cover and info from Tmdb for records.
But I'll try to make a separate plugin for this.

[littlesat]

Why not asking AMC to adapt to us instead on an old version of Enigma2 from opendreambox.org which is closed source now?

And again... when we do not have any sources of AMC we even do not know were to fix issues!!!

Edited by littlesat, 17 June 2012 - 17:43.

[rtzhjgg0]

...we even do not know were to fix issues!!!

Littlesat, you don't need to fix anything on PLi. Just remove the old pipzap code and let users to install (if they wish) the PiPzap-Plugin.
This old pipzap code, will only cause in future troubles/conflicts with other addons (like in the case of AMS).

[littlesat]

What is wrong with the old PipZap code. I know PLi did made some mods in it a very long time ago...? Why depending on a separate PIPzap-Plugin (possibly also closed source)?

Does there a py file exist in the AMC package... If so then someone could adapt the plugin.... an image should not adapt...

Edited by littlesat, 17 June 2012 - 19:36.

[rtzhjgg0]

What is wrong with the old PipZap code...

Your pipzap-code was compiled years ago in the time when pipzap existed only as a patch. But from juni 2011 there is a plugin wich runs on all existent images.

Here is the link: enigma2-plugin-extensions-pipzap


If you remove the old code you will have this advantages:

- no more obsolete code that can cause in future troubles/conflicts with other software.
- PLi users can decide to install PiPzap or not.
- in PiPzap-plugin you can switch/configure three elements:

1 use or not STOP-Key to enable/disable pipzap mode.
2 show or hide in Plugin menu.
3 show or hide indicator label in the opposite corner when pipzap mode is enabled.

[hemispherical1]

Unfortunately the plugin uses the (personally I believe un-enforcable, but OpenPLI honors author's wishes) Creative Commons license with the bizarre rider of "Additionally, this plugin may only be distributed and executed on hardware which
is licensed by Dream Multimedia GmbH".

The same license was the cause of newer versions of webif being dropped, but on the bright side, it prompted the development of OpenWebif.

--
hemi

[littlesat]

PipZap is not the problem as PipZap is working right in PLi... It is the fact that the AMS plugin is not compatible with OpenPli.... and not the image should adapt the plugin should in fact adapt to be compatible. When it was really a bug then it was slightly different. But this time it isn't a bug... PiPZap is made different in PLi.... (instead of pauze we currently use exit....)

And in addition there is a work-a-round. You are still able to fix the issue for AMS when you also install the PiPZap plugin.... So why should we adapt??

But still could someone post the ipk of AMS here so we are al least able to see if a py is included so we are able to verify if it could be adapted?

Edited by littlesat, 18 June 2012 - 06:57.

[rtzhjgg0]

...
But still could someone post the ipk of AMS here so we are al least able to see if a py is included so we are able to verify if it could be adapted?

Here is the ipk of AMS:

Attached Files

•  enigma2-plugin-extensions-advancedmovieselection_2.7-20120601-r0_mips32el.ipk   458.98K   18 downloads

[littlesat]

As far I can see it is a mix of several plugins. Some of them with a creative commons licence and some of them GPL... wierd...

At least most of the source code is available (on the ipk)

It is tuned to the the E2 repo of DMM. As everyone know the storyt,,,,, It could work with OpenPli when someone takes the time to adapt it. I do not see why we should do this as there already exits a work-a-round with the PiPZap.

Save the cover and info from Tmdb for records.

And that part of the code is closed source....

Edited by littlesat, 18 June 2012 - 09:09.

[rtzhjgg0]

Today I found out why AMS runs without problems on AAF: they removed the old pipzap code.

Edited by rtzhjgg0, 18 June 2012 - 09:31.

[MiLo]

Unfortunately the plugin uses the (personally I believe un-enforcable, but OpenPLI honors author's wishes) Creative Commons license with the bizarre rider of "Additionally, this plugin may only be distributed and executed on hardware which
is licensed by Dream Multimedia GmbH".
The same license was the cause of newer versions of webif being dropped, but on the bright side, it prompted the development of OpenWebif.

No, that was the explicit wish of the author not to remove the TPM check.

The underlined part just extends the licence beyond what was already written, allowing it to be used on a proprietary licenced box as long as DMM produces it. So it does no restrict the license.

The Creative Commons license in itself is an open source license with basically the opposite purpose as the GPL: To restrict the user's rights as much as possible.

[blzr]

The underlined part just extends the licence beyond what was already written, allowing it to be used on a proprietary licenced box as long as DMM produces it. So it does no restrict the license.

hmm, are you sure?
actually there are two dmm modified 'CC' licenses,
older:

...
Alternatively, this plugin may be distributed and executed on hardware which
is licensed by Dream Multimedia GmbH.

which adds an exception for dmm allowing them to use plugin commercially...
and the newer 'license':

Additionally, this plugin may only be distributed and executed on hardware which
is licensed by Dream Multimedia GmbH

and such restriction pretty much contradicts /?/ the idea of CC license,
and is rather unenforceable...
//but of course, I'm not licensing expert at all ...

Edited by blzr, 18 June 2012 - 09:55.

[littlesat]

they removed the old pipzap code.

And we do not remove our own pipzap code for a plugin.... As a PLUGIN should adapt and not an IMAGE...

Were are the sources of OpenAAF?

[ims]

I am not sure, but "can be" and can be only" is same for me in this case ...

[rtzhjgg0]

And we do not remove our own pipzap code for a plugin....

I don't belive AAF removed the old pipzap code only because of AMS. I think because a new good-working pipzap-plugin is better than an old patch.

[littlesat]

What is wrong with out own PiPzap...??? And why is older better.... OK it is different... It just means we made it somehow earlier.... and others do adapt something different ;D

And if you want to use AMS... you still can install the pipzap plugin... So where is the issue?

I do even suggest they took ViX code for InfoBarGenerics.py and so on.... they did not even remove something....

Edited by littlesat, 18 June 2012 - 10:39.