136 replies to this topic

[littlesat]

Thanks Dima73

[Dimitrij]

littesat

NimManager.py

line 481

Maybe so?

-					if not currSat.usals.value and x < 34:
+					if not currSat.usals.value and x < 65:

I'm not sure ...

[littlesat]

It was 34.... That was why i missed it... But did you found a bug now or should I make it <66?...

I think it is even better to use a number-of-lnbs global...

[Dimitrij]

It was 34.... That was why i missed it... But did you found a bug now or should I make it <66?...

I think it is even better to use a number-of-lnbs global...

I think < 34 it was a small typo, right  < 33.

+

Satconfig.py-->def fillListWithAdvancedSatEntrys

					self.advancedUsalsEntry = getConfigListEntry(_("Use USALS for this sat"), Sat.usals)
-					self.list.append(self.advancedUsalsEntry)
-					if not Sat.usals.value:
-						self.list.append(getConfigListEntry(_("Stored position"), Sat.rotorposition))
+					if lnbnum < 65:
+						self.list.append(self.advancedUsalsEntry)
+						if not Sat.usals.value:
+							self.list.append(getConfigListEntry(_("Stored position"), Sat.rotorposition))
					self.list.append(getConfigListEntry(_("Tuning step size") + " [" + chr(176) + "]", currLnb.tuningstepsize))

[Dimitrij]

This is just my thoughts

[littlesat]

<34 could be intended.... so I made it <66... then everything is the same as it was before..

 

What is the exact effect of you latest sugestions....

 

I suggest it is even better to use a global for the max_number_of_lnbs or so instead of hardcode numbers...

Edited by littlesat, 24 April 2014 - 17:18.

[Dimitrij]

<34 could be intended.... so I made it <66... then everything is the same as it was before..

 

What is the exact effect of you latest sugestions....

 

I suggest it is even better to use a global for the max_number_of_lnbs or so instead of hardcode numbers...

I think that is correct 65.

Example:

' Satellite '--> All satellites 1(USALS no),that equals 65

This means that for each satellite should be saved position("Stored position"), but ...

All satellites  if  use usals or not works.

 

Correct me if I'm wrong.

[Dimitrij]

Full sugestions...

--- a/NimManager.py
+++ b/NimManager.py
@@ -477,8 +477,7 @@
 						sec.setToneMode(switchParam.ON)
 					elif currSat.tonemode.value == "off":
 						sec.setToneMode(switchParam.OFF)
-
-					if not currSat.usals.value and x < 66:
+					if not currSat.usals.value and x < 65:
 						sec.setRotorPosNum(currSat.rotorposition.value)
 					else:
 						sec.setRotorPosNum(0) #USALS
@@ -1182,7 +1181,17 @@
 					("5", "SatCR 5"), ("6", "SatCR 6"), ("7", "SatCR 7"), ("8", "SatCR 8")]
 
 	prio_list = [ ("-1", _("Auto")) ]
-	prio_list += [(str(prio), str(prio)) for prio in range(65)+range(14000,14065)+range(19000,19065)]
+	for prio in range(65)+range(14000,14065)+range(19000,19065):
+		description = ""
+		if prio == 0:
+			description = _(" (disabled)")
+		elif 0 < prio < 65:
+			description = _(" (lower than any auto)")
+		elif 13999 < prio < 14066:
+			description = _(" (higher than rotor any auto)")
+		elif 18999 < prio < 19066:
+			description = _(" (higher than any auto)")
+		prio_list.append((str(prio), str(prio) + description))
 
 	advanced_lnb_csw_choices = [("none", _("None")), ("AA", _("AA")), ("AB", _("AB")), ("BA", _("BA")), ("BB", _("BB"))]
 	advanced_lnb_csw_choices += [(str(0xF0|y), "Input " + str(y+1)) for y in range(0, 16)]
@@ -1203,8 +1212,8 @@
 	turning_speed_choices = [("fast", _("Fast")), ("slow", _("Slow")), ("fast epoch", _("Fast epoch"))]
 
 	advanced_satlist_choices = nimmgr.satList + [
-		(3601, _('All satellites')+' 1', 1), (3602, _('All satellites')+' 2', 1),
-		(3603, _('All satellites')+' 3', 1), (3604, _('All satellites')+' 4', 1)]
+		(3601, _('All satellites 1 (DiSEqC mode 1.2)'), 1), (3602, _('All satellites 2 (DiSEqC mode 1.2)'), 1),
+		(3603, _('All satellites 3 (DiSEqC mode 1.2)'), 1), (3604, _('All satellites 4 (DiSEqC mode 1.2)'), 1)]
 	advanced_lnb_choices = [("0", _("not available"))] + [(str(y), "LNB " + str(y)) for y in range(1, 65)]
 	advanced_voltage_choices = [("polarization", _("Polarization")), ("13V", _("13 V")), ("18V", _("18 V"))]
 	advanced_tonemode_choices = [("band", _("Band")), ("on", _("On")), ("off", _("Off"))]
--- a/Satconfig.py
+++ b/Satconfig.py
@@ -354,10 +354,6 @@
 					self.list.append(self.uncommittedDiseqcCommand)
 					self.list.append(getConfigListEntry(_("DiSEqC repeats"), currLnb.diseqcRepeats))
 				if currLnb.diseqcMode.value == "1_2":
-					self.list.append(getConfigListEntry(_("Longitude"), currLnb.longitude))
-					self.list.append(getConfigListEntry(" ", currLnb.longitudeOrientation))
-					self.list.append(getConfigListEntry(_("Latitude"), currLnb.latitude))
-					self.list.append(getConfigListEntry(" ", currLnb.latitudeOrientation))
 					if SystemInfo["CanMeasureFrontendInputPower"]:
 						self.advancedPowerMeasurement = getConfigListEntry(_("Use power measurement"), currLnb.powerMeasurement)
 						self.list.append(self.advancedPowerMeasurement)
@@ -375,8 +371,14 @@
 							currLnb.powerMeasurement.value = False
 							currLnb.powerMeasurement.save()
 					self.advancedUsalsEntry = getConfigListEntry(_("Use USALS for this sat"), Sat.usals)
-					self.list.append(self.advancedUsalsEntry)
-					if not Sat.usals.value:
+					if lnbnum < 65:
+						self.list.append(self.advancedUsalsEntry)
+					if Sat.usals.value:
+						self.list.append(getConfigListEntry(_("Longitude"), currLnb.longitude))
+						self.list.append(getConfigListEntry(" ", currLnb.longitudeOrientation))
+						self.list.append(getConfigListEntry(_("Latitude"), currLnb.latitude))
+						self.list.append(getConfigListEntry(" ", currLnb.latitudeOrientation))
+					else:
 						self.list.append(getConfigListEntry(_("Stored position"), Sat.rotorposition))
 					self.list.append(getConfigListEntry(_("Tuning step size") + " [" + chr(176) + "]", currLnb.tuningstepsize))
 					self.list.append(getConfigListEntry(_("Memory positions"), currLnb.rotorPositions))

 

[Dimitrij]

littlesat

Thank you .

[littlesat]

No.... Thank You for completing, as you did several times in the past.... This is very appreciated...!

[gerard0610]

@ littlesat and Dima 73:

 

you both deserve a compliment.

[Huevos]

Thanks from here too.

[Dimitrij]

question...

 

"Committed DiSEqC command" value --> None, AA, AB, BA, BB + Input 1-16

Input 1-16 for diseqc mode/protocol 1.0 is it possible?

[gerard0610]

DiSEqC 1.0 is only 'None, AA, AB, BA, BB' ( as far as I know)

[littlesat]

Indeed diseqc 1.0 is only aa ab ba bb...

[Dimitrij]

http://sourceforge.n...e76abccf8a6818/

[littlesat]

That is old.....

[Rob van der Does]

That may be old, but still valid.

atm the DiSEqC 1.0 allows for AA, AB, BA, BB as well as input 1-16.

Edited by SatKiekerd, 26 April 2014 - 07:40.

[littlesat]

Diseqc 1.1 has this 1.0 is only aa ab ba bb....
I suggest it is old as it was possibly that time a quick fix... And later somehow reverted.

[Rob van der Does]

Diseqc 1.1 has this 1.0 is only aa ab ba bb....

So you didn't even try it? As I said: atm the DiSEqC 1.0 in PLi's tuner config has the inputs 1-16 as well; no point in denying that......